As far as I can tell, partmedia's refactoring of the buy/sell code has rendered cha_shop_bonus obsolete.
I was working with the documentation, and had cha_shop_bonus handled in the handbook generation scripts, only to realize it wasn't being used.
The values get loaded into int_bonuses[] in living.c and can be accessed with get_cha_bonus(). get_cha_bonus() is called in zero places, but has two prototypes (living.h and libproto.h). Thus, it is unused.
Are there plans to use cha_shop_bonus in the buy/sell code, or can it be safely removed? Either way, I can update the documentation script to produce the right values (1 / 1.06 ^ Cha) for now. I just wanted to know if there would be additional adjustments I would need to do later.
cha_shop_bonus in stat_bonus file
Moderator: Board moderators
-
SilverNexus
- Junior member
- Posts: 165
- Joined: Mon Jun 25, 2012 5:33 pm
- Location: Planet Earth
cha_shop_bonus in stat_bonus file
That SilverNexus guy? You needn't worry about him.
He is level negative 4 in oratory, and his singing is worse.
He is level negative 4 in oratory, and his singing is worse.
You're right: cha_shop_bonus is currently unused. It can be safely removed from the code. I originally left it there so that it could be discussed on the mailing list since it was a fairly significant change, but I don't recall what the list decided. If the new charisma bonuses seem reasonable to you, then it can be safely removed.