quiting characters

[Aaron]

shouldnt 'quit character' be remaned to delete character? could be alot less confusing?

Leaf: you should probably unlock your announcment so people can comment on that...

[Leaf]

Leaf: you should probably unlock your announcment so people can comment on that...

I would prefer to keep the announcement area, announcements only.

Discussion of topics (inlcuding announcements) should go in the appropriate subject/threads/etc.

[Aaron]

well you made it sticky, then locked it. still wondering why it isnt fixed yet. of course there hasnt been a new client in a while.

[Rednaxela]

of course there hasnt been a new client in a while.

It's server-side, not on the client. However the client would have to be changed as well otherwise the menus for quit character would be broken for the moment.

[Aaron]

thought it would be a simple client side fix to the menu label? just change "Quit Character" to "Delete Character"

but then again i might be wrong...

[cavesomething]

shouldn't it be rather changing the labels to 'quit', and 'quit and delete character'?

and yes, the client fix is simple....

Code: Select all

Index: gtk/gx11.c
===================================================================
RCS file: /cvsroot/crossfire/client/gtk/gx11.c,v
retrieving revision 1.72
diff -C5 -r1.72 gx11.c
*** gtk/gx11.c  30 May 2005 21:01:57 -0000      1.72
--- gtk/gx11.c  6 Jul 2005 02:23:20 -0000
***************
*** 3058,3074 ****
    menu_items = gtk_menu_item_new ();
    gtk_menu_append(GTK_MENU (filemenu), menu_items);
    gtk_widget_show(menu_items);


!   menu_items = gtk_menu_item_new_with_label("Quit character");
    gtk_menu_append(GTK_MENU (filemenu), menu_items);
    gtk_signal_connect_object(GTK_OBJECT(menu_items), "activate",
                            GTK_SIGNAL_FUNC(sexit), NULL);
    gtk_widget_show(menu_items);

!   menu_items = gtk_menu_item_new_with_label("Quit client");
    gtk_menu_append(GTK_MENU (filemenu), menu_items);
    gtk_signal_connect_object(GTK_OBJECT(menu_items), "activate",
                            GTK_SIGNAL_FUNC(client_exit), NULL);
    gtk_widget_show(menu_items);

--- 3058,3074 ----
    menu_items = gtk_menu_item_new ();
    gtk_menu_append(GTK_MENU (filemenu), menu_items);
    gtk_widget_show(menu_items);


!   menu_items = gtk_menu_item_new_with_label("Quit and Delete character");
    gtk_menu_append(GTK_MENU (filemenu), menu_items);
    gtk_signal_connect_object(GTK_OBJECT(menu_items), "activate",
                            GTK_SIGNAL_FUNC(sexit), NULL);
    gtk_widget_show(menu_items);

!   menu_items = gtk_menu_item_new_with_label("Quit");
    gtk_menu_append(GTK_MENU (filemenu), menu_items);
    gtk_signal_connect_object(GTK_OBJECT(menu_items), "activate",
                            GTK_SIGNAL_FUNC(client_exit), NULL);
    gtk_widget_show(menu_items);

[Rednaxela]

Yes, that works well too. It's just when people type quit as a command that would still be a problem.

[techolous]

just give them a dialog that the "quit" command is depreciated, and to use two other commands to delete their character, and leave, respectively.

[cavesomething]

a better thing to do might be to check the parameters to the quit command, and then if they are blank display

***WARNIG***
the command quit, as well as leaving the server will delete your character permenently. If you only want to exit the client type [I can't remember what it is off-hand]. If you /do/ want to quit your character type 'quit YESIAMSUREIWANTTODOTHIS'

btw, what is the other command that you refer to?

[techolous]

Doesn't exist atm, exept for killing the connection.