newpickup wand/staff/rod

[bencha]

as in cf 1.7 monsters can fire wand/staff/rods ( fear pixies ), it would be nice to autopick up it when you kill the wielder, and not all weapons.

[cavesomething]

I did happen to poke at that myself a while back, on the server side there are a couple of bits that are unused in the pickup string, so it could be implemented fairly easily there (assuming no one has any other use in mind for those bits....).

The modifications to the client I have no idea about though, I don't speak gtk, so can't comment.

[bencha]

ok, i've done the patches, both for the server & the client, and it works.
now, what's the beter way to publish it ?

and now the problem : i've patched the 1.7.0 cf dist, but files have changed on the CVS just where patch will complain ( another newpickup just before mine), so should i do others one for the last CVS version ?

potential soluce : is there someone with cvs modif rights that can do the patch ( just 4 copy&paste, i can give the actual line numbers )

[cavesomething]

I'm not too sure how your patch is different from these two...
http://sourceforge.net/tracker/index.ph ... tid=313833
http://sourceforge.net/tracker/index.ph ... tid=313833

They are probably what you refer to as having broken your patch against 1.7.0.

anyways, regarding submitting patches....

best thing to do is to checkout from CVS, apply the patch, and then diff against CVS.

cvs -z9 -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/crossfire co crossfire
to get the server

and

cvs -z9 -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/crossfire co client
to get the client

this will create two directories client/ and server/ in the directory you are in.
cd into each, and apply the changes you want to make.

then run

cvs -z9 -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/crossfire diff -RC 5 . > bencha_server.diff

in crossfire/

and

cvs -z9 -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/crossfire diff -RC 5 . > bencha_client.diff

in client/

you now have two diff files.

go to http://sourceforge.net/tracker/?group_i ... tid=313833
and create a patch item for your diffs, upload the files you have created, and (optional) bug the cf mailing list to make someone look at them.

[bencha]

thanks cavesomething, i haven't seen these patches.

so, someone else have done it too.

[cavesomething]

if you are going to continue to write code (and I hope that you do) then if you haven't already it is worth your while subscribing to the CVS development mailing list, it will show you all the patches as they get commited, including the ever useful log messages.

http://lists.sourceforge.net/lists/list ... ssfire-cvs

also consider subscribing to the cf dev mailing list, where big features/issues get discussed.

http://mailman.metalforge.org/mailman/l ... /crossfire