The fairly new stat selection window

SilverNexus · Post by **SilverNexus** » Thu Jun 28, 2012 2:22 pm

I was trying to create a character using the stat selection window, but it would crash my server, with a message saying a stat was out of bounds when race was applied, unless Wisdom remained above zero after each race and class were applied to the character.

Also, I noticed the dialog would no longer block you once a stat total hit zero, and I know that stats reach a minimum of one in Crossfire.

I was using the fire hatchling race, which has a -8 penalty to wisdom, so it actually was possible to make some of these situations occur.

Website · Post by **Leaf** » Thu Jun 28, 2012 6:00 pm

Was this with the v1.60 server?

1.70.0 is the latest release, and there has been a number of updates since then -- so if possible, please try and test this on the latest SVN update (r18309).

SilverNexus · Post by **SilverNexus** » Fri Jun 29, 2012 1:58 am

Updated to the latest revision (r18309) at recreated the same effect.

To recreate, try the following setup:

1. Create a new character (obviously)
2. Select the fire hatchling race and monk class, or any other class with a positive wisdom bonus
3. Set wisdom to 8, and whatever with the other stats
4. Select a starting location and give the character a name
5. Hit "Done"

An error box saying "Could not apply race - stat is out of bounds" should appear.

The stats should appear in the client, but any further attempts to rid oneself of the character creation dialogue (no matter what is done with the stats after the error box appears) crash the server.

As far as I can tell, the game is crashing when the -8 Wis modifier for the fire hatchling race is applied, setting the wisdom to zero.

I think a way to fix this would be to make both the race and class stat modifications apply at the same time (make some variables that total the two, then apply the net change)

If you want to keep both modifiers separate, you would just need to add in a check for all stats that prevents stats less than one between the applied race and class stat modifications (in other words, it would check to make sure all race modifiers do not result in a stat less than zero).

EDIT: creating an elf alchemist with base wisdom set at 3 has the same effect.
same goes for a fire hatchling devotee with 6 base wisdom
this bug is not specific to the wisdom stat either -- i got it to happen using a fenx's -4 power modifier as well

Yet, when a stat hits zero after both modifications, the game just bumps it to one.

Shouldn't the game just prevent stats finishing at zero as well?

mwedel · Post by **mwedel** » Fri Jun 29, 2012 7:01 am

Did you update the server to the latest version or just client?

With latest server and client, I am not able to reproduce the problem - in the scenario you describe, with a 0 stat, it will not let me create the character. If I increase that stat so its total is 1, it will let me create the character and the server does not crash.

SilverNexus · Post by **SilverNexus** » Sat Jun 30, 2012 12:46 am

I'll test this as soon as I get the trunk version of the server running -- I'm experiencing some technical difficulties with compiling, and have made a forum post in the help section to receive help on what's going on.

I'm wondering if the reason you couldn't recreate it is that my computer only updated the revision number and nothing else, hence why it never told me what files it was changing, since it changed none. Thus, this may have been an old problem, and my computer was tricking me into thinking it had given me a new version.

Then again, maybe not. We can only wait until I get the server compilation resolved.

As a side note, since you were making sure I had both server and client updated, the client version I now have is trunk and compiled as trunk, ready to go.

mwedel · Post by **mwedel** » Sat Jun 30, 2012 3:40 am

It can be confusing that if you do a svn update in one of the branches, it will state it is updated to some revision, however it still contains the state per that branch.

The SVN versions is global for all branches as directories. Thus, even if on trunk server, you could do a svn update and it state you are at some latest version, but nothing in fact changed from the version you were at before if all the intervening changes were made to the maps or arches.

SilverNexus · Post by **SilverNexus** » Sat Jun 30, 2012 3:56 am

Ah, that's why it wasn't telling me things when it was updating,,, it really wasn't doing anything except revision updating.

Everything makes so much more sense now.

Thank you for your enlightenment.

SilverNexus · Post by **SilverNexus** » Sat Jun 30, 2012 4:42 pm

I looked at the changelog and, in revision 14 thousand-something, sure enough, there was the fix that should have fixed this.

This is what I get for being an svn noob