Map in unlinked Marksel keep causes segfault

[SilverNexus]

I was tinkering with the unlinked Kandora map set, and discovered that a map arch on /unlinked/kandora/dm_keep causes the server to segfault with this output:

Code: Select all

13/11/29 12:39:38 [Error]   Trying to insert object outside the map.
arch map
name map
name_pl map
race /start/HallsOfSelection
slaying /HallOfSelection
face map.111
hp 1
sp 1
x 25
y 19
type 22
subtype 1
materialname mercury
value 300
weight 7200
end

Aborted

The map arch seems to be out of range of the map itself. Should the map arch be removed, or just moved somewhere on to the map?

[SilverNexus]

Hmm... Marksel is already implemented as a set of linked maps....
Well, that explains a little. It also eases the task of setting up Kandora in bigworld (fewer maps to maintain and repair).

[Leaf]

The HallsOfSelection map is no longer used in trunk server. So, this map arch should be removed.

[SilverNexus]

I found the problem's origin.
The map arch in system/map.arc had x and y of 16, so the server simply added that to the location the map was placed, and ended up with a location off the map.
Rather than delete the map arch from the map (which may still need to be done), removing the x and y values from the map arch prevented the segfault.
The map seemed inert, though.

Changes committed to r19160.

[Leaf]

Good catch and nicely done. Thank you!